Change in vdsm[master]: vm: enable disk stats collection on recovery

nsoffer at redhat.com nsoffer at redhat.com
Wed Sep 3 15:28:05 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: enable disk stats collection on recovery
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32406/1//COMMIT_MSG
Commit Message:

Line 7: vm: enable disk stats collection on recovery
Line 8: 
Line 9: In the recovery path we never enable the disk
Line 10: stats collection.
Line 11: This patch fixes that.
> Could you blame the commit that broke this? We may need to backport this pa
No commit "broke" this.

It was 45f3037ca1e88421 - before that, the domain ids were not added at all, which broke vm unpuasing when storage domain becomes up.

So there is no regression here, just incomplete fix.
Line 12: 
Line 13: Change-Id: Ibd7d32373f5a0a7dd4ef88c5a0ad5a9f3d52938c


-- 
To view, visit http://gerrit.ovirt.org/32406
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd7d32373f5a0a7dd4ef88c5a0ad5a9f3d52938c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list