Change in vdsm[master]: vm: enable disk stats collection on recovery
nsoffer at redhat.com
nsoffer at redhat.com
Wed Sep 3 14:58:27 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: vm: enable disk stats collection on recovery
......................................................................
Patch Set 1:
(1 comment)
Nice catch! I think this is my fault - I added the code adding the domain ids to sdIds, and it was done too quickly (urgent bug).
http://gerrit.ovirt.org/#/c/32406/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2895: else:
Line 2896: for drive in devices[DISK_DEVICES]:
Line 2897: if drive['device'] == 'disk' and isVdsmImage(drive):
Line 2898: self.sdIds.append(drive['domainID'])
Line 2899: self.startDisksStatsCollection()
Is it possible that we have no matching device in devices[DISK_DEVICES]?
I think this should be:
domains = [drive['domainID']] for drive in devices[DISK_DEVICES]
if drive['device'] == 'disk' and isVdsmImage(drive)]
if domains:
self.sdIds.extend(domains)
self.startDisksStatsCollection()
Line 2900:
Line 2901: for devType, devClass in self.DeviceMapping:
Line 2902: for dev in devices[devType]:
Line 2903: self._devices[devType].append(devClass(self.conf, self.log,
--
To view, visit http://gerrit.ovirt.org/32406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd7d32373f5a0a7dd4ef88c5a0ad5a9f3d52938c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list