Change in vdsm[ovirt-3.5]: iface_sampling: Fix debug logging samples

ybronhei at redhat.com ybronhei at redhat.com
Wed Sep 3 12:49:52 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: iface_sampling: Fix debug logging samples
......................................................................


iface_sampling: Fix debug logging samples

Currently we have a debug logging entry whenever the tx/rx rates go
over 100%. In this log, we try to help debugging of the issue by
printing the sample value of rx and tx for all the samples in the
AVERAGING_WINDOW (size 5).

The problem comes from the fact that the decision to log is taken
by checking samples hs0 and hs1 iterating over all the devices
existing on the older hs1. However, there is no guarantee that
the devices would exist in hs2, hs3, ..., hs_AVERAGING_WINDOW.

The fix is to simply not include the samples for which the device
is missing.

Change-Id: Ibaa80f5fe069875d8e48deb1783f102b2da8f39d
Bug-Url: https://bugzilla.redhat.com/1116577
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/29916
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31789
Reviewed-by: Genadi Chereshnya <gcheresh at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Genadi Chereshnya: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Antoni Segura Puimedon: Verified



-- 
To view, visit http://gerrit.ovirt.org/31789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaa80f5fe069875d8e48deb1783f102b2da8f39d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list