Change in vdsm[ovirt-3.5]: hsm: check volume existence in prepareImage

ybronhei at redhat.com ybronhei at redhat.com
Wed Sep 3 12:49:25 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: hsm: check volume existence in prepareImage
......................................................................


hsm: check volume existence in prepareImage

This patch introduces a check in prepareImage to return a consistent
error (VolumeDoesNotExist) when the volume to prepare is not found.

Before this patch the error was:

 UnboundLocalError: local variable 'leafInfo' referenced
   before assignment

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133617
Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31937
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
(cherry picked from commit 0e9c6a4fb2f126d10d445289753abbf03ed867ae)
Reviewed-on: http://gerrit.ovirt.org/32337
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/storage/hsm.py
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved
  Federico Simoncelli: Verified
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/32337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list