Change in vdsm[master]: profiling: Add support for memory profiling

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 2 17:37:03 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: profiling: Add support for memory profiling
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32019/2/lib/vdsm/profile_mem.py
File lib/vdsm/profile_mem.py:

Line 28: 
Line 29: try:
Line 30:     # dowser dependencies
Line 31:     import cherrypy
Line 32:     from PIL import Image, ImageDraw
> Why do you import these here? they are not used in this module.
If indeed needed, it must be documented here.
Line 33:     # dowser profiler itself
Line 34:     import dowser
Line 35: except ImportError:
Line 36:     _SUPPORTED = False


-- 
To view, visit http://gerrit.ovirt.org/32019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list