Change in vdsm[master]: tests: Use frozenset instead of set

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 2 16:21:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: Use frozenset instead of set
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/31786/3/tests/toolTests.py
File tests/toolTests.py:

Line 73
Line 74
Line 75
Line 76
Line 77
> you guys usually don't like it when we use lists where we can
You don't care what the function does with the list/tuple, so it does not matter.

With tuples you will have to write ('c,') for one element tuple, while with lists ['c'] works, so it is nicer to use.

In application code, I may prefer tuple because it may be more efficient, but in test code it does not matter.


-- 
To view, visit http://gerrit.ovirt.org/31786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list