Change in vdsm[master]: profiling: Add support for memory profiling
ykaplan at redhat.com
ykaplan at redhat.com
Tue Sep 2 16:06:27 UTC 2014
Yeela Kaplan has posted comments on this change.
Change subject: profiling: Add support for memory profiling
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/32019/2/lib/vdsm/profile_mem.py
File lib/vdsm/profile_mem.py:
Line 52:
Line 53:
Line 54: def stop():
Line 55: """ Stops application memory profiling """
Line 56: pass # not yet needed
Why is this not needed?
Wouldn't we want to stop the thread once the profiling is stopped?
Line 57:
Line 58:
Line 59: def is_enabled():
Line 60: return config.getboolean('vars', 'profile_memory_enable')
--
To view, visit http://gerrit.ovirt.org/32019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib56b65513e0118b68cd43791bf655c928d6a26e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list