Change in vdsm[master]: vdsm: add hostdev rules for vfio

danken at redhat.com danken at redhat.com
Tue Sep 2 14:27:44 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: add hostdev rules for vfio
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/32218/4/vdsm/vdsm-vfio.rules.in
File vdsm/vdsm-vfio.rules.in:

Line 22: #
Line 23: # These rules change ownership and permissions
Line 24: # of vfio devices spawned in /dev/vfio.
Line 25: 
Line 26: KERNEL=="[0-9][0-9]*", SUBSYSTEM=="vfio" GROUP:="@QEMUGROUP@" MODE="0660"
I don't think that this is a good idea - we should still work in a finer granularity. We don't want to change ownership of devices that are to be kept away of qemu's touch.

We should add a rule per appropriated device (see supervdsm's appropriateDevice). Sorry for not being clear about it in my former comment.


-- 
To view, visit http://gerrit.ovirt.org/32218
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7dc8b786e1dd7399411639fa3fe35372708333
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list