Change in vdsm[master]: vdsm: initial split of vm devices

fromani at redhat.com fromani at redhat.com
Tue Sep 2 12:44:27 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: initial split of vm devices
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

very nice start.

http://gerrit.ovirt.org/#/c/29250/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 748:             if attr == 'nicModel' and value == 'pv':
Line 749:                 kwargs[attr] = 'virtio'
Line 750:             elif attr == 'network' and value == '':
Line 751:                 kwargs[attr] = DUMMY_BRIDGE
Line 752:         vmdevices.Base.__init__(self, conf, log, **kwargs)
let's make use of super() - here and below, in a followup patch.
Line 753:         self.sndbufParam = False
Line 754:         self._customize()
Line 755: 
Line 756:     def _customize(self):


-- 
To view, visit http://gerrit.ovirt.org/29250
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63b602851c17697259e86dfad3a9063447c57e50
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list