Change in vdsm[master]: vdsm: remove protected attribute access in VmStatsThread

danken at redhat.com danken at redhat.com
Tue Sep 2 11:12:07 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vdsm: remove protected attribute access in VmStatsThread
......................................................................


vdsm: remove protected attribute access in VmStatsThread

Accessing internal elements is evil, VmStatsThread accessed
vm devices through _vm._devices[DISK_DEVICES], which can be
replaced by _vm.getDiskDevices()

Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32246
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit http://gerrit.ovirt.org/32246
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list