Change in vdsm[master]: tests: Use frozenset instead of set

mtayer at redhat.com mtayer at redhat.com
Tue Sep 2 10:38:09 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tests: Use frozenset instead of set
......................................................................


Patch Set 3:

(2 comments)

Agree to patch

nits.

http://gerrit.ovirt.org/#/c/31786/3//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-08-26 19:36:27 +0300
Line 6: 
Line 7: tests: Use frozenset instead of set
Line 8: 
Line 9: Using frozenset ensure that bad code trying ot mutate the return value
ensures?
Line 10: of requires() will fail.
Line 11: 
Line 12: Instead of replacing all set(...) calls with frozenset(...), I'm
Line 13: creating the frozenset in __init__, so there is no way to create an


http://gerrit.ovirt.org/#/c/31786/3/tests/toolTests.py
File tests/toolTests.py:

Line 73
Line 74
Line 75
Line 76
Line 77
you guys usually don't like it when we use lists where we can
use tuple, can we use tuple here?

(I understand that in the mock constructor you handle mutability, but am talking about the allocation here)


-- 
To view, visit http://gerrit.ovirt.org/31786
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11835fe49ffcc3e4cbfdbc4272bc31429b6be2e1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list