Change in vdsm[master]: vm: avoid race while setting guest cpu status

danken at redhat.com danken at redhat.com
Tue Sep 2 10:15:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vm: avoid race while setting guest cpu status
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/29113/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2362:         here we want to synchronize the access to guestCpuRunning
Line 2363:         made by callback with the pause/cont methods.
Line 2364:         To do so we reuse guestCpuLocked.
Line 2365:         """
Line 2366:         if not guestCpuLocked:
this is inherently raceful - but as you say in the commit message we have a deeper issue here, with _acquireCpuLockWithTimeout()'s brokenness.
Line 2367:             self._acquireCpuLockWithTimeout()
Line 2368:         try:
Line 2369:             self._guestCpuRunning = isRunning
Line 2370:         finally:


-- 
To view, visit http://gerrit.ovirt.org/29113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aea96c7122d60e6cb888273678b565c3f3e537f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list