Change in vdsm[master]: vdsm: remove protected attribute access in VmStatsThread

fromani at redhat.com fromani at redhat.com
Tue Sep 2 09:49:08 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: remove protected attribute access in VmStatsThread
......................................................................


Patch Set 1: Code-Review+1

Agreed. In the long term, we should get rid of the *lesser* evil (trivial helper methods), but for the time being let's just focus on the greater ones.

-- 
To view, visit http://gerrit.ovirt.org/32246
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list