Change in vdsm[master]: hsm: check volume existence in prepareImage

nsoffer at redhat.com nsoffer at redhat.com
Tue Sep 2 09:46:57 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: check volume existence in prepareImage
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/31937/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3217:         :type sdUUID: UUID
Line 3218:         :param spUUID: The UUID of the storage pool that owns the volume.
Line 3219:         :type spUUID: UUID
Line 3220:         :param imgUUID: The UUID of the image contained on the volume.
Line 3221:         :type imgUUID: UUID
For another patch: document the leafUUID parameter
Line 3222:         """
Line 3223:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 3224: 
Line 3225:         imgVolumesInfo = []


-- 
To view, visit http://gerrit.ovirt.org/31937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iceac3934b5eb3b7d3d68ea80ddd29cd9fe919c6c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list