Change in vdsm[master]: getVMFullList fails when processing externally managed vms

danken at redhat.com danken at redhat.com
Tue Sep 2 08:46:29 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: getVMFullList fails when processing externally managed vms
......................................................................


getVMFullList fails when processing externally managed vms

When we send 22k response we get -1 during send. After the investigation
we found that m2crypto ignores error codes and returns -1. We are not
sure which error is returned. It can be one of SSL_ERROR_WANT_WRITE,
SSL_ERROR_WANT_READ, SSL_ERROR_NONE, SSL_ERROR_ZERO_RETURN.

When we get -1 we need to get back to poll loop so we override send
method and return 0 when we see -1 which fixes the issue.


Bug-Url: https://bugzilla.redhat.com/1135959
Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: http://gerrit.ovirt.org/32263
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Saggi Mizrahi: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia728691880771388b6179e85a97df3f303aeddf8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list