Change in vdsm[master]: Configure iSCSI iface.net_ifacename
sgotliv at redhat.com
sgotliv at redhat.com
Tue Sep 2 05:30:03 UTC 2014
Sergey Gotliv has posted comments on this change.
Change subject: Configure iSCSI iface.net_ifacename
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/31534/3/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:
Line 325: self.name = name
Line 326:
Line 327: ni = netinfo.NetInfo()
Line 328: network = tuple(ni.getBridgedNetworksAndVlansForIface(name))
Line 329:
> Sergey, I'm not sure I follow. If target IP is enough, we don't need to pas
> Sergey, I'm not sure I follow. If target IP is enough, we don't need to pass any
> net_iface name.
Target IP is enough when both source NICs reside on different subnets. Unfortunately in our particular case both NICs are on the same subnet.
> If we care about the source net_iface, Engine should send it, as it does today.
> However, if the iface has no IP address, I think Engine should send the bridge that > is built on top of it. I see no use for passing through the ip-less iface. Am I right?
Correct!
So now is a dilemma:
I hoped to avoid changes in VDSM because for customer its probably easier to deploy 1 Engine instead of N VDSM nodes. However, the signature of this VDSM's method accepting only mac address and/or ip address but sending mac or/and ip address from the Engine doesn't resolve the problem (see 2 last Amador's comments).
Therefore we have to calculate "net_ifacename" which is a bridge or NIC as you said before.
So who will do that Engine or VDSM?
Change in VDSM is a self-contained and doesn't require any further changes in the Engine.
Change in Engine will require to change VDSM as well and Engine doesn't keep this information explicitly :-), related model in Engine has a boolean "isBridged" and String networkName. I just hope that if "idBridged == true" then networkName is the name of the bridge... :-).
Dan, Amador - VDSM or Engine? I will vote +1 for any of both.
Line 330: if network:
Line 331: self._conf['iface.net_ifacename'] = network[0][0]
Line 332: else:
Line 333: self._conf['iface.net_ifacename'] = name
--
To view, visit http://gerrit.ovirt.org/31534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ebb2f272669b753700b57486d869b21dd16f2d6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list