Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

danken at redhat.com danken at redhat.com
Mon Sep 1 14:44:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.ovirt.org/#/c/31561/11/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 201: task_upgraded_version_check(){
Line 202:     local upgraded_ver_file="@VDSMLIBDIR@/upgraded_version"
Line 203:     if [ -f "${upgraded_ver_file}" ]; then
Line 204:         local ret=0
Line 205:         if cat "${upgraded_ver_file}" | grep -q '^vdsm-4\.10\.'; then
"cat" is superfluous, grep accepts a filename as arg.
Line 206:              # We need to treat the upgrade from 4.10.x specifically
Line 207:              # by running manual configure command
Line 208:              "$VDSM_TOOL" configure --force
Line 209:              ret=$?


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list