Change in vdsm[master]: tc tests: Fix icmp test frame to have payload

danken at redhat.com danken at redhat.com
Mon Sep 1 14:33:41 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tc tests: Fix icmp test frame to have payload
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/32161/1//COMMIT_MSG
Commit Message:

Line 10: packet to have a proper long and nice description. I generated the
Line 11: frame with 'scapy' and I did not include any payload to ICMP.
Line 12: 
Line 13: For some reason, the jenkins unit tests pass but on my machines it
Line 14: is causing the mirroring target not to see the frame. This patch
Any idea why a payload is required on your host? Which kernel is it running? Is it reproducible?

 ./run_tests_local.sh tcTests.py 

passes nicely as it is on my el6.
Line 15: fixes the issue.
Line 16: 
Line 17: Change-Id: I5f2d64c3dbc621f062274afb343ad56048b36180


-- 
To view, visit http://gerrit.ovirt.org/32161
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f2d64c3dbc621f062274afb343ad56048b36180
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list