Change in vdsm[master]: Live Merge: Suspend disk stats collection during pivot

alitke at redhat.com alitke at redhat.com
Mon Sep 1 12:58:23 UTC 2014


Adam Litke has posted comments on this change.

Change subject: Live Merge: Suspend disk stats collection during pivot
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/31367/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 5642:         if mode in (LiveMergeCleanupThread.MODE_CLEANUP,
Line 5643:                     LiveMergeCleanupThread.MODE_PIVOT):
Line 5644:             self.log.info("Live merge job completed (job %s)", jobID)
Line 5645:             self._syncVolumeChain(drive)
Line 5646:             self.startDisksStatsCollection()
> Ok, makes sense for the disk being merged. But stats collection is done for
Added a TODO to stop stats collection for a single disk.
Line 5647:         else:
Line 5648:             raise RuntimeError("Invalid mode: '%s'" % mode)
Line 5649: 
Line 5650:     def _initLegacyConf(self):


-- 
To view, visit http://gerrit.ovirt.org/31367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08689aec4d61871a568a6f92661b560fbf4d0b57
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list