Change in vdsm[master]: Live Merge: Suspend disk stats collection during pivot
Federico Simoncelli
fsimonce at redhat.com
Mon Sep 1 12:55:32 UTC 2014
Federico Simoncelli has posted comments on this change.
Change subject: Live Merge: Suspend disk stats collection during pivot
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/31367/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 5649: self.vm.log.info("Requesting pivot to complete active layer commit "
Line 5650: "(job %s)", self.jobId)
Line 5651: try:
Line 5652: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT
Line 5653: ret = self.vm._dom.blockJobAbort(self.drive.name, flags)
Please leave TODOs/FIXMEs for things you're not able to address now. Thanks!
Line 5654: except:
Line 5655: self.vm.startDisksStatsCollection()
Line 5656: raise
Line 5657: else:
--
To view, visit http://gerrit.ovirt.org/31367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08689aec4d61871a568a6f92661b560fbf4d0b57
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list