Change in vdsm[master]: ipwrapper: Use zombiereaper to wait for process

nsoffer at redhat.com nsoffer at redhat.com
Mon Sep 1 09:12:09 UTC 2014


Nir Soffer has uploaded a new change for review.

Change subject: ipwrapper: Use zombiereaper to wait for process
......................................................................

ipwrapper: Use zombiereaper to wait for process

Commit aea8aab95f eliminated ip process zombies by waiting for ip
process.  This is may introduce unlimited wait if the process is not
responsive.  We can avoid this issue by using zombiereaper.

Note that zombiereaper requires explicit initialization (registering
signal handler for SIGCHLD), so this make ipwrapper less useful as
generic utility.

Change-Id: I26263c5b4811d7f46f7c65d1d1b00bd96af02eb8
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/vdsm/ipwrapper.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/32216/1

diff --git a/lib/vdsm/ipwrapper.py b/lib/vdsm/ipwrapper.py
index af31159..781e95b 100644
--- a/lib/vdsm/ipwrapper.py
+++ b/lib/vdsm/ipwrapper.py
@@ -27,6 +27,7 @@
 import signal
 import socket
 import struct
+import zombiereaper
 
 from netaddr.core import AddrFormatError
 from netaddr import IPAddress
@@ -638,7 +639,7 @@
 
     def stop(self):
         self.proc.kill()
-        self.proc.wait()
+        zombiereaper.autoReapPID(self.proc.pid)
 
     @classmethod
     def _parseLine(cls, line):


-- 
To view, visit http://gerrit.ovirt.org/32216
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I26263c5b4811d7f46f7c65d1d1b00bd96af02eb8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list