Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required

ybronhei at redhat.com ybronhei at redhat.com
Mon Sep 1 00:31:28 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:

Line 202:     local upgraded_ver_file="@VDSMLIBDIR@/upgraded_version"
Line 203:     if [ -f "${upgraded_ver_file}" ]; then
Line 204:         local ret=0
Line 205:         local ver="$(cat ${upgraded_ver_file})"
Line 206:         if echo "${ver}" | grep -q '^vdsm-4\.10\.'; then
> two commits are fine as well.
we won't make it that way to 3.5. please ack if acceptable.  when I'll need to add new case I'll get back to it. but the flow is valid and works
Line 207:              # We need to treat the upgrade from 4.10.x specifically
Line 208:              # by running manual configure command
Line 209:              "$VDSM_TOOL" configure --force
Line 210:              ret=$?


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list