Change in vdsm[master]: hostdev: add check for hostdev passthrough to caps

danken at redhat.com danken at redhat.com
Fri Oct 31 12:27:36 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: add check for hostdev passthrough to caps
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/30471/6//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Not perfectly accurate source but the support for passthrough can be
Line 10: obtained through cmdline. This indicates whether user *wanted* to
Line 11: enable the support, not if it is fully supported by hardware and/or
Line 12: configuration.
Sorry for not asking this before, but why do we want to know that? What would happen if iommu is disabled in bios? Would attachments fail graciously?

Why would an ovirt user want to explicitly disable iommu?
Line 13: 
Line 14: Change-Id: I789f93679740e87b2f5a88351261bc58852990d4


http://gerrit.ovirt.org/#/c/30471/6/vdsm/caps.py
File vdsm/caps.py:

Line 294: 
Line 295: 
Line 296: def _has_iommu_support_in_cmdline(cmdline):
Line 297:     if 'iommu' in cmdline and ('intel_iommu=off' not in cmdline and
Line 298:                                'iommu=off' not in cmdline):
this would return True if cmdline has the string "biommu=officer". That's not likely, but if we HAVE to parse the command line, let us do it properly (use shlex.split()).
Line 299:         return True
Line 300: 
Line 301:     return False
Line 302: 


-- 
To view, visit http://gerrit.ovirt.org/30471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I789f93679740e87b2f5a88351261bc58852990d4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list