Change in vdsm[master]: clean dhclient processes that are left after functional tests

ibarkan at redhat.com ibarkan at redhat.com
Thu Oct 30 05:59:55 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: clean dhclient processes that are left after functional tests
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/34366/7/tests/functional/dhcp.py
File tests/functional/dhcp.py:

Line 132: 
Line 133:     def _is_running(self):
Line 134:         try:
Line 135:             return os.readlink('/proc/{0}/exe'.format(self.pid)) == \
Line 136:                 _DHCLIENT_BINARY.cmd
> This is hard to read, doing too much in the same line, and includes code th
Done
Line 137:         except OSError as err:
Line 138:             if err.errno != ENOENT:
Line 139:                 raise
Line 140:             return False  # no such pid


-- 
To view, visit http://gerrit.ovirt.org/34366
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I458aa38415c697d3863e173444ff921d759166a2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list