Change in vdsm[master]: hooks: Add a hook to configure IPv6 networking through custo...

danken at redhat.com danken at redhat.com
Wed Oct 29 17:52:11 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add a hook to configure IPv6 networking through custom properties
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/README
File vdsm_hooks/ipv6/README:

Line 5: Requirements:
Line 6: * oVirt-3.5 (?started supporting custom properties?)
Line 7: 
Line 8: Usage:
Line 9: In the oVirt UI edit custom network properties and, for the keys 'ipv6addr'
Please explain how to make this work in Engine. Give explicit names for custom properties. Compare to http://gerrit.ovirt.org/#/c/34114/8/vdsm_hooks/allocate_net/README
Line 10: and 'ipv6gateway'
Line 11: set the command line parameters that one would pass to the *** command


http://gerrit.ovirt.org/#/c/34571/2/vdsm_hooks/ipv6/ipv6.py
File vdsm_hooks/ipv6/ipv6.py:

Line 28:     for network, attrs in setup_nets_config['request']['networks'].items():
Line 29:         if 'remove' in attrs:
Line 30:             continue
Line 31:         elif 'custom' in attrs:
Line 32:             _process_network(network, attrs)
you should finish with

 hooking.write_json()
Line 33: 
Line 34: 
Line 35: def _process_network(network, attrs):
Line 36:     """Add an IPv6 address and a gateway to the network."""


-- 
To view, visit http://gerrit.ovirt.org/34571
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0e427b182a1742999eeb14e004209b511668ba2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list