Change in vdsm[master]: tool: sebool is-configured when selinux is disabled will alw...

danken at redhat.com danken at redhat.com
Tue Oct 28 16:42:44 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: tool: sebool is-configured when selinux is disabled will always be MAYBE
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/34516/4/lib/vdsm/tool/configurators/sebool.py
File lib/vdsm/tool/configurators/sebool.py:

Line 71:         True all selinux booleans in the list above are set properly
Line 72:         """
Line 73:         ret = YES
Line 74:         if utils.get_selinux_enforce_mode() == -1:
Line 75:             ret = MAYBE
> I think YES is better.
But this configurator did not do it's job (maybe). So why lie and say that everything is ok?
Line 76:         else:
Line 77:             import seobject
Line 78:             sebool_obj = seobject.booleanRecords()
Line 79:             sebool_status = sebool_obj.get_all()


-- 
To view, visit http://gerrit.ovirt.org/34516
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d728fac39be454600235d80c8c24641d6c309a4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list