Change in vdsm[master]: vm: log xml from/to libvirt at 'info' level

nsoffer at redhat.com nsoffer at redhat.com
Tue Oct 28 12:48:30 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: vm: log xml from/to libvirt at 'info' level
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34358/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2843:         # domDependentInit, after the migration is completed.
Line 2844: 
Line 2845:         if not self.recovering and initDomain:
Line 2846:             domxml = hooks.before_vm_start(self._buildDomainXML(), self.conf)
Line 2847:             self.log.info(domxml)
> Yes, I see your point.
Please mark with TODO: info logs that should be debug logs, but you are not confident enough to fix now.
Line 2848: 
Line 2849:         if self.recovering:
Line 2850:             self._dom = NotifyingVirDomain(
Line 2851:                 self._connection.lookupByUUIDString(self.id),


-- 
To view, visit http://gerrit.ovirt.org/34358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list