Change in vdsm[master]: netinfo: Replace misused asserts with InvalidConfiguration
osvoboda at redhat.com
osvoboda at redhat.com
Mon Oct 27 10:21:02 UTC 2014
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Replace misused asserts with InvalidConfiguration
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Good catch! :-) I have a note how to improve your nice messages even more.
http://gerrit.ovirt.org/#/c/34361/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 859: for port in ports:
Line 860: if port in self.vlans:
Line 861: if vlan is not None:
Line 862: raise InvalidConfiguration(
Line 863: "Unexpected vlan: %s exepected: None" % (vlan,))
I recommend a comma to separate values visually :-)
"Unexpected vlan: %s, expected: None" % vlan)
Line 864: nic = getVlanDevice(port)
Line 865: vlan = getVlanID(port)
Line 866: if self.vlans[port]['iface'] != nic:
Line 867: raise InvalidConfiguration(
--
To view, visit http://gerrit.ovirt.org/34361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99ee49aa7e2364f57112e2452e3eab3940b6b00a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list