Change in vdsm[ovirt-3.5]: spec: qemu-img is required during the tests

nsoffer at redhat.com nsoffer at redhat.com
Sun Oct 26 14:16:46 UTC 2014


Hello Douglas Schilling Landgraf, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/34479

to review the following change.

Change subject: spec: qemu-img is required during the tests
......................................................................

spec: qemu-img is required during the tests

The tests use vdsm/qemuimg module, which checks where qemu-img is
located. We can probably mock it but it does not seem worth the effort.

Change-Id: I609904760c47c064ae24047da32e9e8879b1e476
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33507
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/34479/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 024cfdc..4d0c08d 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -83,6 +83,7 @@
 BuildRequires: python-pthreading
 BuildRequires: python-cpopen >= 1.3
 BuildRequires: python-ioprocess >= 0.12
+BuildRequires: qemu-img
 BuildRequires: rpm-python
 BuildRequires: libnl
 BuildRequires: libselinux-python


-- 
To view, visit http://gerrit.ovirt.org/34479
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I609904760c47c064ae24047da32e9e8879b1e476
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list