Change in vdsm[master]: vdsm: add functionality to detach host devices

fromani at redhat.com fromani at redhat.com
Fri Oct 24 11:48:25 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: add functionality to detach host devices
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/32389/3/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 57: 
Line 58: def _get_device_ref_and_params(device_name):
Line 59:     libvirt_device = libvirtconnection.get().\
Line 60:         nodeDeviceLookupByName(device_name)
Line 61:     return libvirt_device, _parse_device_params(libvirt_device.XMLDesc(0))
> No, no, no, no please no - the patch was remade from caching version to thi
Yep, now I remember. Right, discard my comment.
Line 62: 
Line 63: 
Line 64: def _get_devices_from_vms(vmContainer):
Line 65:     """


-- 
To view, visit http://gerrit.ovirt.org/32389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I530fed56831314286942b8afa62900208812bfb5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list