Change in vdsm[master]: image: use qemu-img convert to copy internal volumes

nsoffer at redhat.com nsoffer at redhat.com
Thu Oct 23 18:25:29 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: image: use qemu-img convert to copy internal volumes
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33355/2/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 432:                                                    volUUID=srcVol.volUUID)
Line 433:                     srcFormat = volume.fmt2str(srcVol.getFormat())
Line 434:                     dstFormat = volume.fmt2str(dstVol.getFormat())
Line 435: 
Line 436:                     pntVol = dstVol.getParentVolume()
Would you rename "pnt" to "parent"?
Line 437: 
Line 438:                     if pntVol is not None:
Line 439:                         backing = volume.getBackingVolumePath(
Line 440:                             imgUUID, pntVol.volUUID)


-- 
To view, visit http://gerrit.ovirt.org/33355
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c740d88d52ca678d6c02d0ea500d2459c26560c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list