Change in vdsm[master]: libvirtconnection: add credentials other then defalut

fromani at redhat.com fromani at redhat.com
Thu Oct 23 15:34:02 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: libvirtconnection: add credentials other then defalut
......................................................................


Patch Set 8:

(2 comments)

the commit message needs to be updated; besides that, i think is good enough both for v2v (IIUC) and as first step toward libvirtconnection cleanup.

There is still quite some work to be done - get() does quite a lot of stuff and so forth, but better to do that in different future patches.

http://gerrit.ovirt.org/#/c/34293/8//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-10-20 17:34:34 +0300
Line 4: Commit:     Shahar Havivi <shaharh at redhat.com>
Line 5: CommitDate: 2014-10-23 16:20:12 +0300
Line 6: 
Line 7: libvirtconnection: add credentials other then defalut
the "subject" part was left behind a bit. I suggest to change to something like

"libvirtconnection: add function to create a new connection"

or whatever wording you prefer.
Line 8: 
Line 9: Adding username, passwd, and uri for libvirtconnection module -
Line 10: Enabling to connect to libvirt with other credentials then
Line 11: the default configuration.


Line 7: libvirtconnection: add credentials other then defalut
Line 8: 
Line 9: Adding username, passwd, and uri for libvirtconnection module -
Line 10: Enabling to connect to libvirt with other credentials then
Line 11: the default configuration.
Same for this paragraph, which needs to be updated
Line 12: 
Line 13: This will be needed by the v2v future patches which will needed to
Line 14: connect to remove libvirt given a uri.
Line 15: 


-- 
To view, visit http://gerrit.ovirt.org/34293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3481d56ee19afec14b36b98b412278148b26379e
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list