Change in vdsm[master]: libvirt: do not always log failed libvirt calls

danken at redhat.com danken at redhat.com
Thu Oct 23 09:03:48 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: libvirt: do not always log failed libvirt calls
......................................................................


libvirt: do not always log failed libvirt calls

The libvirtconnection module provides libvirt connection handling
for VDSM. libvirt connection and domain objects have their callable
methods transparently wrapped, to let VDSM automatically
detect and react to disconnection.

A side effect of this wrapping is that exceptions are intercepted
before to be reraised and delivered to the caller, and a
quite cryptic and not very informative message is logged for
each exception.

Given that the wrapper is -and has to be- generic, this logging
has no choice in turn but to be generic, but this adds little
value to logs, and surely adds noise and concern to the user.

Proper action must be done in the client code, which must handle
exception correctly and do whatever it is needed, maybe
just log the error, maybe silencing it.

So, this patch just drops the extra debug log.

Change-Id: I170e1870e1d4759c1c7310d71f00450b6e560690
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33937
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/libvirtconnection.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Michal Skrivanek: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/33937
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I170e1870e1d4759c1c7310d71f00450b6e560690
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list