Change in vdsm[master]: sampling: extract SampleWindow class

fromani at redhat.com fromani at redhat.com
Thu Oct 23 07:53:41 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: sampling: extract SampleWindow class
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/33783/2//COMMIT_MSG
Commit Message:

Line 7: sampling: extract SampleWindow class
Line 8: 
Line 9: The existing AdvancedStatsFunction does actually
Line 10: two different things: wraps a client-provided
Line 11: callable, and implements a slinding window for samples.
> slinding -> sliding
Done
Line 12: 
Line 13: This patch splits the two responsabilities, while
Line 14: preserving the existing API for backward compatibility's
Line 15: sake.


Line 11: callable, and implements a slinding window for samples.
Line 12: 
Line 13: This patch splits the two responsabilities, while
Line 14: preserving the existing API for backward compatibility's
Line 15: sake.
> Who is using the old api? Why to update client to new api?
Actually there is no good reason to do so. I'll just update the existing user (AdvancedStatsFunction) - and of course fix this commit message.
Line 16: 
Line 17: Other than cleanup for the sake of clarity and testability,
Line 18: future sampling refactoring patches will still
Line 19: need to store samples and handle a sliding window;


-- 
To view, visit http://gerrit.ovirt.org/33783
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48fe9e7f8ed3f5ec677d8f91a82cb70d0bdbb2e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list