Change in vdsm[master]: virt: migration: rename cancel->stop method

fromani at redhat.com fromani at redhat.com
Thu Oct 23 07:25:12 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: migration: rename cancel->stop method
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/33030/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 384:             self._vm._dom.migrateSetMaxDowntime(downtime, 0)
Line 385: 
Line 386:         self._vm.log.debug('migration downtime thread exiting')
Line 387: 
Line 388:     def stop(self):
> It is nice that we can use with running - but is this really a cancel, stop
It is a stop, because the downtime thread has no means (and IMO it makes no sense) to discard its progress.

Just to recap, downtime thread just periodically  updates downtime thread according to a given formula -so far a basic linear interpolation and feed libvirt with this data.

So, discard the progress would mean to reset the value to the initial one, which is indeed easy to do (a couple lines of code) but gives no value.
Line 389:         self._vm.log.debug('stopping migration downtime thread')
Line 390:         self._stop.set()
Line 391: 
Line 392: 


-- 
To view, visit http://gerrit.ovirt.org/33030
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia938ae0fa5bf3ddd16ffc992299566b618ea4677
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list