Change in vdsm[master]: libvirtconnection: add credentials other then defalut

shavivi at redhat.com shavivi at redhat.com
Wed Oct 22 12:14:55 UTC 2014


Shahar Havivi has posted comments on this change.

Change subject: libvirtconnection: add credentials other then defalut
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/34293/5/lib/vdsm/libvirtconnection.py
File lib/vdsm/libvirtconnection.py:

Line 149:     with __connectionLock:
Line 150:         conn = __connections.get(id(target))
Line 151:         if not conn:
Line 152:             log.debug('trying to connect libvirt')
Line 153:             with open(constants.P_VDSM_LIBVIRT_PASSWD) as passwd_file:
it use to be file() instead of open()
now the libvirtconnectionTests.py fail with:
--------------------------------------------------------------------
  File "/home/shahar/rpmbuild/BUILD/vdsm-4.16.0/lib/vdsm/libvirtconnection.py", line 153, in get
    with open(constants.P_VDSM_LIBVIRT_PASSWD) as passwd_file:
AttributeError: __exit__
--------------------------------------------------------------------
it may be that the problem is using with...
Line 154:                 passwd = passwd_file.readline().rstrip("\n")
Line 155:             conn = open('qemu:///system', constants.SASL_USERNAME, passwd)
Line 156:             __connections[id(target)] = conn
Line 157: 


-- 
To view, visit http://gerrit.ovirt.org/34293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3481d56ee19afec14b36b98b412278148b26379e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list