Change in vdsm[master]: caps: Additional ppc64 hardware information
vdelima at redhat.com
vdelima at redhat.com
Tue Oct 21 17:31:45 UTC 2014
Vitor de Lima has posted comments on this change.
Change subject: caps: Additional ppc64 hardware information
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/33857/2/vdsm/ppc64HardwareInfo.py
File vdsm/ppc64HardwareInfo.py:
Line 41
Line 42
Line 43
Line 44
Line 45
> if os.path.exists() can/should be dropped, please drop it in its own patch,
Done
Line 20:
Line 21: import os
Line 22:
Line 23:
Line 24: def getFromDeviceTree(hwInfo, key, treeProperty):
> please mark as _private. Also, this function does not "get", it "update"s h
Done
Line 25: path = '/proc/device-tree/%s' % treeProperty
Line 26: try:
Line 27: with open(path) as f:
Line 28: value = f.readline().rstrip('\0').replace(',', '')
Line 26: try:
Line 27: with open(path) as f:
Line 28: value = f.readline().rstrip('\0').replace(',', '')
Line 29: hwInfo[key] = value
Line 30: except IOError:
> Which IOErrors are expected? Why are they to be ignored?
Done
Line 31: pass
Line 32:
Line 33:
Line 34: @utils.memoized
--
To view, visit http://gerrit.ovirt.org/33857
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list