Change in vdsm[master]: protocolDetector: Remove unneeded poll flags

danken at redhat.com danken at redhat.com
Tue Oct 21 10:05:20 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: protocolDetector: Remove unneeded poll flags
......................................................................


protocolDetector: Remove unneeded poll flags

Protocol detector was using uneeded poll flags in the eventmask; POLLHUP
and POLLERR are output only, as documented in poll(2) and Python library
reference:
https://docs.python.org/2.6/library/select.html#select.poll.register

POLLPRI is needed only to detect out-of-band data, which the other side
can send using MSG_OOB flag, as documented in send(2). Since we don't
use out-of-band data, we don't need to check for it.

Since the READ_ONLY_MASK contains only select.POLLIN, and the
READ_WRITE_MASK was used only once, they were removed.  Developers
maintaing this code are expected to know these constants.

Change-Id: I94c535c7aa94410eb3158b298c3df3d1738abe74
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33912
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-by: Saggi Mizrahi <smizrahi at redhat.com>
---
M vdsm/protocoldetector.py
1 file changed, 7 insertions(+), 12 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Saggi Mizrahi: Looks good to me, approved
  Dima Kuznetsov: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/33912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I94c535c7aa94410eb3158b298c3df3d1738abe74
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list