Change in vdsm[master]: VDSM hook for random network allocation during VM power on
danken at redhat.com
danken at redhat.com
Tue Oct 21 07:46:45 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/34114/6/vdsm_hooks/allocate_net/before_device_create.py
File vdsm_hooks/allocate_net/before_device_create.py:
Line 41: 'prog': sys.argv[0]}
Line 42:
Line 43:
Line 44: def _parse_nets():
Line 45: return [net for net in os.environ[AVAIL_NETS_KEY].split()]
> I tested a broken configuration where non-existent networks are configured
I agree with Ido and see no need for "asking for permission".
Line 46:
Line 47:
Line 48: def _get_random_network():
Line 49: available_nets = _parse_nets()
--
To view, visit http://gerrit.ovirt.org/34114
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c76994918750e7eef460411acc337599b0186
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list