Change in vdsm[master]: network: ConfigurationApplier parent object

asegurap at redhat.com asegurap at redhat.com
Mon Oct 20 12:30:45 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: network: ConfigurationApplier parent object
......................................................................


Patch Set 4: Code-Review-1

ifcfg, iproute2 and pyroute_two decided to have config appliers. That is not part of the API (there is no config applier API, except a de-facto one). I'm not sure that we want that. I think that it would probably be better to just have some shared module level function of libvirt net creation/deletion that the configurators could use, rather than introduce inheritance.

-- 
To view, visit http://gerrit.ovirt.org/34205
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib842e0c3b4973f6a9e7a1b66f3786499da39857d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list