Change in vdsm[master]: VDSM hook for random network allocation during VM power on

asegurap at redhat.com asegurap at redhat.com
Mon Oct 20 12:22:54 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: VDSM hook for random network allocation during VM power on
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/34114/6/vdsm_hooks/allocate_net/README
File vdsm_hooks/allocate_net/README:

Line 11: Installation:
Line 12: * Use engine-config to set the appropriate custom properties as such:
Line 13: 
Line 14: Custom property for a specific vNIC profile:
Line 15:     sudo engine-config -s CustomDeviceProperties="{type=interface;prop={equivnets=(.+)(,\s*.+)*}}"
I think this should be updated for the 'whitespace as separator'
Line 16:     sudo service ovirt-engine restart
Line 17: 
Line 18: * Verify that the custom properties were added properly:
Line 19:     sudo engine-config -g CustomDeviceProperties


http://gerrit.ovirt.org/#/c/34114/6/vdsm_hooks/allocate_net/before_device_create.py
File vdsm_hooks/allocate_net/before_device_create.py:

Line 41:        'prog': sys.argv[0]}
Line 42: 
Line 43: 
Line 44: def _parse_nets():
Line 45:     return [net for net in os.environ[AVAIL_NETS_KEY].split()]
there should be filtering for if the bridge exists.
Line 46: 
Line 47: 
Line 48: def _get_random_network():
Line 49:     available_nets = _parse_nets()


-- 
To view, visit http://gerrit.ovirt.org/34114
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib14c76994918750e7eef460411acc337599b0186
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list