Change in vdsm[master]: setupNetworks: doesn't remove broken nw from runningConfig

danken at redhat.com danken at redhat.com
Mon Oct 20 11:15:22 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: setupNetworks: doesn't remove broken nw from runningConfig
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/33995/8//COMMIT_MSG
Commit Message:

Line 10: is not listed in netinfo, but it's in libvirt, _delBrokenNetwork()
Line 11: is called.
Line 12: 
Line 13: The problem is that when the network doesn't have an existing device,
Line 14: we only remove it from libvirt and leave it in RunningConfig.
> For that we should have a better handling of out of sync conditions in a se
Cool, I'm not asking to fix everything in this patch. I only ask to specify in the commit message what happens in can of inconsistency.
Line 15: 
Line 16: Now _delBrokenNetwork() remove broken network from runningConfig.
Line 17: 
Line 18: Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12


-- 
To view, visit http://gerrit.ovirt.org/33995
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list