Change in vdsm[master]: ioprocess: Move and reword rename() warning

danken at redhat.com danken at redhat.com
Mon Oct 20 10:37:38 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: ioprocess: Move and reword rename() warning
......................................................................


ioprocess: Move and reword rename() warning

The warning was appearing even when people use the function in the
correct manner.

Let it be on the record that my original intent was to move the log line
to only display when a non-empty directory is being renamed instead of
every time.

But one of the requirements from my reviewers was to use the warnings
module instead making things more "correct" in the price of making the
line itself useless as no one turns on warnings in VDSM and there
is no way to atomically ignore warnings in a thread safe manner for
parts of the code so we can't even turn them on. Also, warnings go to
stderr by default which means that even if you turn them on no one will
see them.

Note: I only use the bug in the bug-url as it's partially related and it
feels to trivial to get a new bug opened and acked.

Change-Id: I6d83f91803515845c993c01c23390aaf1d757dff
Bug-Url: http://bugzilla.redhat.com/1131867
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/32194
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/outOfProcess.py
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Saggi Mizrahi: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32194
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d83f91803515845c993c01c23390aaf1d757dff
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list