Change in vdsm[master]: hba: Rescan using SCSI layer

smizrahi at redhat.com smizrahi at redhat.com
Mon Oct 20 06:56:18 UTC 2014


Saggi Mizrahi has posted comments on this change.

Change subject: hba: Rescan using SCSI layer
......................................................................


Patch Set 2: Code-Review-1

This patch is going in a loop.
I admit I haven't been following the changes trusting that someone was making sure they made since.

You can't do write "- - -" as it will block and if there is a problem VDSM will get stuck. You need to do it out of process. This will mean adding an IOProcess pool to SuperVDSM since IIRC you need to be root to push these values.

-- 
To view, visit http://gerrit.ovirt.org/34245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list