Change in vdsm[master]: tool: change configurators from classes to modules.

nsoffer at redhat.com nsoffer at redhat.com
Sun Oct 19 14:32:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:

Line 36: #
Line 37: # MAYBE = VDSM configured module already, but on force configure vdsm will
Line 38: #         set configurations to defaults parameters.
Line 39: #
Line 40: YES, NO, MAYBE = range(3)
> @Yaniv can do, notice it will make configurators import it  from outside mo
ok


http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/certificates.py
File lib/vdsm/tool/configurators/certificates.py:

Line 39: 
Line 40: name = "certificates"
Line 41: 
Line 42: 
Line 43: def _exec_vdsm_gencerts():
> What if I prefer to order them in logical order?
Putting public function before private is the logical order :-)

Try to explain why the first function in this module is this function.
Line 44:     rc, out, err = execCmd(
Line 45:         (
Line 46:             os.path.join(
Line 47:                 P_VDSM_EXEC,


http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 307: 
Line 308: # version != PACKAGE_VERSION since we do not want to update configuration
Line 309: # on every update. see 'configuration versioning:' at Configfile.py for
Line 310: # details.
Line 311: CONF_VERSION = '4.13.0'
> well I think this is rather private: it is used outside only at tests. In t
There is no other way to make them private :-)
Line 312: 
Line 313: PKI_DIR = os.path.join(constants.SYSCONF_PATH, 'pki/vdsm')
Line 314: LS_CERT_DIR = os.path.join(PKI_DIR, 'libvirt-spice')
Line 315: 


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list