Change in vdsm[master]: tool: change configurators from classes to modules.

mtayer at redhat.com mtayer at redhat.com
Sun Oct 19 13:26:28 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 28: name:         [mandatory attribute]
Line 29: 
Line 30:     Return module name to be used with the --module option.
Line 31: 
Line 32: requires:     [optional attribute]
> Lets remove all the optional attribue and make it simpler.
I like the idea of removing all the optional's.
This will save all the getattr.

 I think saggy might object to this since it makes sense to
him that all the default sit here. @Saggy?

 I would prefer writing default imp at every implementor
than using # default.py.
That is similar to inheritance (only more verbose), so reader
would still have to read 3 files to understand the code.)
Line 33: 
Line 34:     Return set of other modules names required by this module.
Line 35: 
Line 36:     Those modules will be included even if not provided in --module.


Line 65: s
> I think rather than looking at defaults around the code, it'll be easier fo
I'm thinking about Nir's suggestion where all default and 
non default behavior go in modules. This meaning we won't 
have optional stuff. What do you think?


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list