Change in vdsm[master]: tool: change configure verb logic.

mtayer at redhat.com mtayer at redhat.com
Sun Oct 19 12:59:12 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: change configure verb logic.
......................................................................


Patch Set 1:

(1 comment)

@Nir I believe this bug can manifest
(for example : 'vdsm-tool --module= certificates' should work.)
but I will know better once I do more test during verification.

We did not see it since it is always easy to just do --force.

 I did not split to two changes since new behavior is easier to
express in this new layout(that was my motive for it).

 As for rebasing, this might be worth rebasing on master,
I just fear that since no one ever saw this bug probably 
(since to configure libvirt you would have to use --force anyway)
this is in fact more of a change than a bug fix.

http://gerrit.ovirt.org/#/c/34100/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 132:     """
Line 133:     args = _parse_args(*args)
Line 134: 
Line 135:     sys.stdout.write("\nChecking configuration status...\n\n")
Line 136:     configurer_to_trigger = [c for c in args.modules if filter_(c, args)]
> filter_ is not a good name, it does not filter anything (taking our some it
done.
Line 137: 
Line 138:     services = []
Line 139:     for c in configurer_to_trigger:
Line 140:         for s in getattr(c, 'services', ()):


-- 
To view, visit http://gerrit.ovirt.org/34100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I166fbae855ebff93ef84270f11b74f32fcc115c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list