Change in vdsm[master]: tool: autoload modules.

mtayer at redhat.com mtayer at redhat.com
Sun Oct 19 12:42:38 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: autoload modules.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34049/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 120:     sys.stdout.write("\nChecking configuration status...\n\n")
Line 121:     for c in args.modules:
Line 122:         isconfigured = getattr(c, 'isconfigured', lambda: configurators.NO)()
Line 123:         override = args.force and isconfigured != configurators.YES
Line 124:         if not override and not getattr(c, 'validate', lambda: True)():
> after this change you should be about to do _CONFIGURATORS["libvirt"].valid
We don't need to do _CONFIGURATORS["libvirt"]
since all the relevant modules are already in args.module.

This is a patch about auto reloading configurators.
Line 125:             raise configurators.InvalidConfig(
Line 126:                 "Configuration of %s is invalid" % c.name
Line 127:             )
Line 128:         if override or isconfigured == configurators.NO:


-- 
To view, visit http://gerrit.ovirt.org/34049
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc14a1c409ee607e18d42adcd8a54759d8dbf6d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list