Change in vdsm[ovirt-3.5]: nwfilter: Do not attempt to re-define the nwfilter when not ...

ybronhei at redhat.com ybronhei at redhat.com
Sun Oct 19 08:15:36 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: nwfilter: Do not attempt to re-define the nwfilter when not undefining
......................................................................


nwfilter: Do not attempt to re-define the nwfilter when not undefining

Undefining a filter is an operation that can fail. The fact that we
had the same exception swallowing for two operations, looking up and
discovering led us to the wrong assumption then of defining again the
filter even when it had been looked up fine but could not be
undefined.

The most sensible behavior to take for 3.5 is to just consider the
failure to undefine properly and re-define it only in the case of
failure to look up.

Change-Id: Ia284c0554ef86a4668808b26523fbb3b51baebcc
Bug-Url: https://bugzilla.redhat.com/1150718
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33993
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34206
---
M lib/vdsm/tool/nwfilter.py
1 file changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia284c0554ef86a4668808b26523fbb3b51baebcc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list