Change in vdsm[master]: tool: change configurators from classes to modules.

ybronhei at redhat.com ybronhei at redhat.com
Sun Oct 19 07:02:09 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

hard to find mistakes. it looks good to me

http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:

Line 36: #
Line 37: # MAYBE = VDSM configured module already, but on force configure vdsm will
Line 38: #         set configurations to defaults parameters.
Line 39: #
Line 40: YES, NO, MAYBE = range(3)
this can move to configure.py if it does not introduce an api but only helper objects.


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list